Fix #5428: DataGrid with template columns causes crash when scrolling#11068
Open
tom-englert wants to merge 1 commit intodotnet:mainfrom
Open
Fix #5428: DataGrid with template columns causes crash when scrolling#11068tom-englert wants to merge 1 commit intodotnet:mainfrom
tom-englert wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null reference exception crash that occurs when scrolling DataGrid controls with template columns. The issue manifests as occasional application crashes that cannot be handled by user code during items-control scrolling operations.
- Adds a null check for dataItem before attempting to access it in the automation peer collection logic
- Skips processing of null items instead of crashing when they are encountered
- Provides a defensive programming approach to prevent unhandleable exceptions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dotnet-policy-service
bot
added
PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5428
Main PR
Description
During scroll of items-controls there are occasional null reference exceptions that crash the application. There is no chance to handle these exceptions, because there is no user code in the stack trace.
This PR adds the missing null check to avoid the null reference exceptions.
Customer Impact
Actually there are occasional crashes of the application that are not fixable by user code, see e.g. dotnet/ResXResourceManager#430
This problem occurs in any version of DotNet or NetFramework.
This PR fixes the application crashes.
Testing
No testing, impossible to build and run locally.
Risk
Low, it's just adding a null-check before code that crashes on null items.
Microsoft Reviewers: Open in CodeFlow